From 66d7872e43fefeb341e71862b82a431bf2bb7791 Mon Sep 17 00:00:00 2001 From: Oleg Fayans Date: Oct 18 2016 15:30:37 +0000 Subject: Reverted the essertion for replica uninstall returncode As the issue with ipa installer always returning 0 returncode was addressed, the test needs to be made aware of this change. https://fedorahosted.org/freeipa/ticket/6401 Reviewed-By: Martin Basti Reviewed-By: Martin Babinsky --- diff --git a/ipatests/test_integration/test_replica_promotion.py b/ipatests/test_integration/test_replica_promotion.py index 2ef44d5..98200dd 100644 --- a/ipatests/test_integration/test_replica_promotion.py +++ b/ipatests/test_integration/test_replica_promotion.py @@ -352,12 +352,8 @@ class TestProhibitReplicaUninstallation(IntegrationTest): result = self.replicas[0].run_command(['ipa-server-install', '--uninstall', '-U'], raiseonerr=False) - # Due to ticket 3230 server installation/uninstallation always returns - # 0 unless an uncaught exception occurs. Once this issue is properly - # addressed, please care to change expected return code in the - # following assert from 0 to something else. assert_error(result, "Removal of '%s' leads to disconnected" - " topology" % self.replicas[0].hostname, 0) + " topology" % self.replicas[0].hostname, 1) self.replicas[0].run_command(['ipa-server-install', '--uninstall', '-U', '--ignore-topology-disconnect'])