From 51a483084be40f9523fde80a616568e20fc643e7 Mon Sep 17 00:00:00 2001
From: Simo Sorce <simo@redhat.com>
Date: Aug 28 2013 10:43:02 +0000
Subject: kdb-mspac: Fix out of bounds memset


This memset was harmless as the following data is then set again, but an
optimizing compiler might conceivably reorder instructions causing issues.

CoverityID: 11909

Fixes:
https://fedorahosted.org/freeipa/ticket/3883

---

diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c
index 32e6ca3..ac6a6eb 100644
--- a/daemons/ipa-kdb/ipa_kdb_mspac.c
+++ b/daemons/ipa-kdb/ipa_kdb_mspac.c
@@ -775,7 +775,7 @@ static krb5_error_code ipadb_fill_info3(struct ipadb_context *ipactx,
     }
 
     /* always zero out, not used for Krb, only NTLM */
-    memset(&info3->base.LMSessKey, '\0', sizeof(info3->base.key));
+    memset(&info3->base.LMSessKey, '\0', sizeof(info3->base.LMSessKey));
 
     /* TODO: fill based on objectclass, user vs computer, etc... */
     info3->base.acct_flags = ACB_NORMAL; /* samr_AcctFlags */