From 4297ad6db0d4f39d82fd155323163df92b2b7894 Mon Sep 17 00:00:00 2001
From: David Kupka <dkupka@redhat.com>
Date: Mar 21 2017 08:46:44 +0000
Subject: ipapython.ipautil.nolog_replace: Do not replace empty value


When provided empty value in nolog parameter nolog_replace added 'XXXXXXXX'
three (once for plain value, once for http quoted value and last time for shell
quoted value) times before every character (including terminating '\0') in the string.

https://pagure.io/freeipa/issue/6738

Reviewed-By: Pavel Vomacka <pvomacka@redhat.com>

---

diff --git a/ipapython/ipautil.py b/ipapython/ipautil.py
index 60b4a37..cd66328 100644
--- a/ipapython/ipautil.py
+++ b/ipapython/ipautil.py
@@ -505,7 +505,7 @@ def run(args, stdin=None, raiseonerr=True, nolog=(), env=None,
 def nolog_replace(string, nolog):
     """Replace occurences of strings given in `nolog` with XXXXXXXX"""
     for value in nolog:
-        if not isinstance(value, six.string_types):
+        if not value or not isinstance(value, six.string_types):
             continue
 
         quoted = urllib.parse.quote(value)