From 279bb8fb7fde1eba3ac3dcb0cb5a87f3a211f537 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud Date: Jul 26 2019 09:53:13 +0000 Subject: Azure pipeline: report failure in prepare-build step The azure pipeline defines a "prepare build" step that installs the FreeIPA development dependencies but the step does not report failures of the dnf builddep command. As a consequence, subsequent steps may fail (for instance because of components not installed such as tox) but are hard to diagnose. The fix reports the command failure. Fixes: https://pagure.io/freeipa/issue/8022 Reviewed-By: Alexander Bokovoy Reviewed-By: Rob Crittenden --- diff --git a/ipatests/azure/templates/prepare-build.yml b/ipatests/azure/templates/prepare-build.yml index 71c4c6a..d3c3df2 100644 --- a/ipatests/azure/templates/prepare-build.yml +++ b/ipatests/azure/templates/prepare-build.yml @@ -16,7 +16,7 @@ steps: sudo dnf -y module enable nodejs:12 sudo dnf makecache || : echo "Installing base development environment" - sudo dnf install -y gdb make autoconf rpm-build gettext-devel automake libtool docker python3-paramiko python3-pyyaml || : + sudo dnf install -y gdb make autoconf rpm-build gettext-devel automake libtool docker python3-paramiko python3-pyyaml echo "Installing FreeIPA development dependencies" - sudo dnf builddep -y --skip-broken -D "with_wheels 1" -D "with_lint 1" --spec freeipa.spec.in --best --allowerasing --setopt=install_weak_deps=False || : + sudo dnf builddep -y --skip-broken -D "with_wheels 1" -D "with_lint 1" --spec freeipa.spec.in --best --allowerasing --setopt=install_weak_deps=False displayName: Prepare build environment