From 246e722b4fb9a3a33c650cf536d2b0f51a1923b7 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Apr 23 2014 11:16:34 +0000 Subject: ipa_range_check: Make a new copy of forest_root_id attribute for range_info struct Not making a new copy of this attribute creates multiple frees caused by multiple pointers to the same forest_root_id from all the range_info structs for all the domains belonging to given forest. Part of: https://fedorahosted.org/freeipa/ticket/4137 Reviewed-By: Alexander Bokovoy --- diff --git a/daemons/ipa-slapi-plugins/ipa-range-check/ipa_range_check.c b/daemons/ipa-slapi-plugins/ipa-range-check/ipa_range_check.c index fca4819..9a51d41 100644 --- a/daemons/ipa-slapi-plugins/ipa-range-check/ipa_range_check.c +++ b/daemons/ipa-slapi-plugins/ipa-range-check/ipa_range_check.c @@ -147,7 +147,7 @@ static char* get_forest_root_id(struct domain_info *head, char* domain_id) { if (domain_id != NULL) { while(head) { if (strcasecmp(head->domain_id, domain_id) == 0) { - return head->forest_root_id; + return slapi_ch_strdup(head->forest_root_id); } head = head->next; }