From 1439764c0e8ab9fd046c465e00f065684682f6b0 Mon Sep 17 00:00:00 2001
From: Serhii Tsymbaliuk <stsymbal@redhat.com>
Date: Jun 25 2021 13:42:20 +0000
Subject: WebUI: Fix certificate serial number representation


Big numbers are automatically translated to scientific notation in JavaScript.
It causes an issue with some certificate serial numbers.
The fix normalizes the notation base on original value from serial_number_hex.

The implementation works only for browsers that support BigInt.
It would not work for old browsers like Internet Explorer.

Ticket: https://pagure.io/freeipa/issue/8754

Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>

---

diff --git a/install/ui/src/freeipa/certificate.js b/install/ui/src/freeipa/certificate.js
index 542a156..dc8f06f 100644
--- a/install/ui/src/freeipa/certificate.js
+++ b/install/ui/src/freeipa/certificate.js
@@ -20,6 +20,7 @@
  */
 
 define([
+    'dojo/_base/declare',
     'dojo/_base/lang',
     'dojo/on',
     './builder',
@@ -34,10 +35,11 @@ define([
     './text',
     './widget',
     './widgets/DropdownWidget',
-    './dialog'],
+    './dialog',
+    './field'],
     function(
-        lang, on, builder, datetime, metadata_provider, IPA, $, menu,
-        phases, reg, rpc, text, widget_mod, DropdownWidget) {
+        declare, lang, on, builder, datetime, metadata_provider, IPA, $, menu,
+        phases, reg, rpc, text, widget_mod, DropdownWidget, dialog, field) {
 
 var exp = IPA.cert = {};
 
@@ -1371,6 +1373,7 @@ IPA.cert.cert_widget = function(spec) {
         if (!certificate ) certificate = {};
 
         that.certificate = certificate;
+        that.certificate.serial_number = IPA.cert.normalize_sn(that.certificate);
 
         that.update_displayed_data();
     };
@@ -1641,7 +1644,8 @@ return {
                 {
                     name: 'serial_number',
                     primary_key: true,
-                    width: '90px'
+                    width: '90px',
+                    adapter: IPA.cert.SerialNumberAdapter
                 },
                 'subject',
                 'cacn',
@@ -1905,6 +1909,25 @@ IPA.cert.cert_update_policy = function(spec) {
     return IPA.facet_update_policy(spec);
 };
 
+IPA.cert.normalize_sn = function(cert) {
+    // In case the value is too long we need to prevent translating it
+    // to a scientific number but keep original notation.
+    if (
+        typeof(cert.serial_number) == 'number' &&
+        window.BigInt !== undefined
+    ) {
+        var sn = BigInt(cert.serial_number_hex);
+        return sn.toString();
+    }
+    return cert.serial_number;
+};
+
+IPA.cert.SerialNumberAdapter = declare([field.Adapter], {
+    load: function(data) {
+        return IPA.cert.normalize_sn(data);
+    }
+});
+
 exp.remove_menu_item = function() {
     if (!IPA.cert.is_enabled()) {
         menu.remove_item('authentication/cert');