03cd914 pylint: Skip use-implicit-booleaness-not-comparison

1 file Authored by slev 2 years ago, Committed by rcritten 2 years ago,
1 file changed. 1 lines added. 0 lines removed.
    pylint: Skip use-implicit-booleaness-not-comparison
    
    Pylint 2.12.0 introduced new checker:
    > Used when Pylint detects that collection literal comparison is being
      used to check for emptiness; Use implicit booleaness insteadof a
      collection classes; empty collections are considered as false
    
    Comparison of variable to equality to collection:
    > Lexicographical comparison between built-in collections works as follows:
      For two collections to compare equal, they must be of the same type,
      have the same length, and each pair of corresponding elements must
      compare equal (for example, [1,2] == (1,2) is false because the type is
      not the same).
      Collections that support order comparison are ordered the same as their
      first unequal elements (for example, [1,2,x] <= [1,2,y] has the same
      value as x <= y). If a corresponding element does not exist, the shorter
      collection is ordered first (for example, [1,2] < [1,2,3] is true).
    
    So, `assert value == {}` is not the same as `assert not value`.
    
    Fixes: https://pagure.io/freeipa/issue/9117
    Signed-off-by: Stanislav Levin <slev@altlinux.org>
    Reviewed-By: Rob Crittenden <rcritten@redhat.com>
    
        
file modified
+1 -0