weblatebot / certmonger

Forked from certmonger 2 years ago
Clone

8a47783 Don't report a spurious error if no SCEP pkiMessage is ready yet

Authored and Committed by rcritten 2 years ago
1 file changed. 16 lines added. 10 lines removed.
    Don't report a spurious error if no SCEP pkiMessage is ready yet
    
    On a brand new request in the state op_pkcsreq there will be no
    pkiMessage to send yet because there is no CSR yet.
    
    It correctly detects this state but also displays the message:
    
        Error reading request.  Expected PKCS7 data containing a
        PKCSReq pkiMessage, got nothing.
    
    This is confusing if the request eventually succeeds.
    
    It really only needs to report this if it is passed in a file name
    to read the message from, otherwise silently return
    CM_SUBMIT_STATUS_NEED_SCEP_MESSAGES.
    
    The same issue existed in the op_get_cert_initial state.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1253009
    
        
file modified
+16 -10