From 126dc98c82ba2acffcc3b8ebd3984e5e3428685d Mon Sep 17 00:00:00 2001 From: Michel Alexandre Salim Date: Jan 18 2021 08:45:05 +0000 Subject: Some typo and formatting fixes for Node.js packaging guidelines - unuique => unique - Use _..._ for directory names - align fields in example spec - remove leading _ for link to nodejs-packaging repo Signed-off-by: Michel Alexandre Salim --- diff --git a/guidelines/modules/ROOT/pages/Node.js.adoc b/guidelines/modules/ROOT/pages/Node.js.adoc index 3d42f36..4236964 100644 --- a/guidelines/modules/ROOT/pages/Node.js.adoc +++ b/guidelines/modules/ROOT/pages/Node.js.adoc @@ -72,7 +72,7 @@ The licenses of the bundled Node.js modules need to be in the spec file. If you Each time you update your package, you need to verify the bundled licenses against https://fedoraproject.org/wiki/Licensing:Main#Software_License_List[Fedoras Software License List]. -List all unuique licenses on the License: line of your spec file. https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F[Seperate each license with the word "and"] +List all unique licenses on the License: line of your spec file. https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F[Seperate each license with the word "and"] .... License: and and @@ -116,7 +116,7 @@ If your packages does not need one of the tarballs, then change these instructio Note1: The setup of the prod and dev tarballs will soon become a macro. At the time of this writting, they are not. -Note2: The tarball with the dev dependencies needs to be unpacked in %check and not in %prep to avoid accidentally bundling the unpackaged dependencies that are only needed for testing. +Note2: The tarball with the dev dependencies needs to be unpacked in +%check+ and not in +%prep+ to avoid accidentally bundling the unpackaged dependencies that are only needed for testing. .... ... @@ -176,7 +176,7 @@ It also adds virtual provides in the form `+npm(+``+)+` to identify modules list === Provides bundled -It also automatically adds bundled provides in the form `+bundled() = +` to identify bundled modules. Bundled modules must be in either the node_modules or node_modules_prod directories to be automatically added. +It also automatically adds bundled provides in the form `+bundled() = +` to identify bundled modules. Bundled modules must be in either the _node_modules_ or _node_modules_prod_ directories to be automatically added. === Correcting Dependencies @@ -287,7 +287,7 @@ For convienence, %nodejs_symlink_deps also accepts a `+--check+` argument, which == Bundling Script -It is recommended to use the nodejs-packaging-bundler script found in the Fedora nodejs-packaging-bundler package. More documentation for it can be found at the https://src.fedoraproject.org/rpms/nodejs-packaging/[_Fedora nodejs-packaging repo] . +It is recommended to use the nodejs-packaging-bundler script found in the Fedora nodejs-packaging-bundler package. More documentation for it can be found at the https://src.fedoraproject.org/rpms/nodejs-packaging/[Fedora nodejs-packaging repo] . == Example Spec @@ -306,10 +306,10 @@ Source1: %{npm_name}-%{version}-nm-prod.tgz Source2: %{npm_name}-%{version}-nm-dev.tgz Source3: %{npm_name}-%{version}-bundled-licenses.txt -BuildArch: noarch +BuildArch: noarch ExclusiveArch: %{nodejs_arches} noarch -Requires: nodejs +Requires: nodejs BuildRequires: nodejs-devel %description