From cd761147ae7cfe33e1da99e60e1088f73032473a Mon Sep 17 00:00:00 2001
From: Mike McLean <mikem@redhat.com>
Date: Aug 14 2018 21:12:12 +0000
Subject: PR#1000: Fix target handling in make_task


Merges #1000
https://pagure.io/koji/pull-request/1000

Fixes: #998
https://pagure.io/koji/issue/998
cancel build doesn't work for images

---

diff --git a/hub/kojihub.py b/hub/kojihub.py
index d8c9bea..5eb8424 100644
--- a/hub/kojihub.py
+++ b/hub/kojihub.py
@@ -549,16 +549,16 @@ def make_task(method, arglist, **opts):
                 hastarget = True
                 break
         if hastarget:
-            if target is None:
-                policy_data['target'] = None
-            elif isinstance(target, dict):
+            if isinstance(target, dict):
                 if 'name' not in target:
-                    hastarget = False
                     logger.warning("Bad build target parameter: %r", target)
+                    target = None
                 else:
                     target = target.get('name')
-        if hastarget:
-            policy_data['target'] = get_build_target(target, strict=True)['name']
+            if target is None:
+                policy_data['target'] = None
+            else:
+                policy_data['target'] = get_build_target(target, strict=True)['name']
         t_opts = params.get('opts', {})
         policy_data['scratch'] = t_opts.get('scratch', False)