From 555abdde6efb177983f5d9695317c800bf117552 Mon Sep 17 00:00:00 2001
From: Tomas Kopecek <tkopecek@redhat.com>
Date: Dec 11 2019 12:48:56 +0000
Subject: [web] human-friendly file sizes in taskinfo page


Fixes: https://pagure.io/koji/issue/1819

---

diff --git a/www/kojiweb/rpminfo.chtml b/www/kojiweb/rpminfo.chtml
index fbb9f88..fe7e843 100644
--- a/www/kojiweb/rpminfo.chtml
+++ b/www/kojiweb/rpminfo.chtml
@@ -59,7 +59,7 @@
     </tr>
     #end if
     <tr>
-      <th>Size</th><td>$rpm.size</td>
+      <th>Size</th><td>$util.formatThousands($rpm.size)</td>
     </tr>
     <tr>
       <th><label title="The MD5 digest of the combined header and payload contents. You can query it by `rpmkeys -Kv foo.rpm`">SIGMD5</label></th><td>$rpm.payloadhash</td>
@@ -236,11 +236,11 @@
           </tr>
           <tr class="list-header">
             <th><a href="rpminfo?fileOrder=$util.toggleOrder($self, 'name', 'fileOrder')$util.passthrough_except($self, 'fileOrder', 'fileStart')#filelist">Name</a> $util.sortImage($self, 'name', 'fileOrder')</th>
-            <th><a href="rpminfo?fileOrder=$util.toggleOrder($self, 'size', 'fileOrder')$util.passthrough_except($self, 'fileOrder', 'fileStart')#filelist">Size</a> $util.sortImage($self, 'size', 'fileOrder')</th>
+            <th align="right"><a href="rpminfo?fileOrder=$util.toggleOrder($self, 'size', 'fileOrder')$util.passthrough_except($self, 'fileOrder', 'fileStart')#filelist">Size</a> $util.sortImage($self, 'size', 'fileOrder')</th>
           </tr>
           #for $file in $files
           <tr class="$util.rowToggle($self)">
-            <td><a href="fileinfo?rpmID=$rpm.id&amp;filename=$quote($file.name)">$util.escapeHTML($file.name)</a></td><td>$file.size</td>
+            <td><a href="fileinfo?rpmID=$rpm.id&amp;filename=$quote($file.name)">$util.escapeHTML($file.name)</a></td><td align="right">$util.formatThousands($file.size)</td>
           </tr>
           #end for
         </table>
diff --git a/www/lib/kojiweb/util.py b/www/lib/kojiweb/util.py
index d8fa83e..a7bdc09 100644
--- a/www/lib/kojiweb/util.py
+++ b/www/lib/kojiweb/util.py
@@ -486,6 +486,9 @@ def formatMode(mode):
 
     return result
 
+def formatThousands(value):
+    return '{:,}'.format(value)
+
 def rowToggle(template):
     """If the value of template._rowNum is even, return 'row-even';
     if it is odd, return 'row-odd'.  Increment the value before checking it.