From 46752299378f2d33f65aa03eb1da9fbee0d2c7d9 Mon Sep 17 00:00:00 2001
From: Tomas Kopecek <tkopecek@redhat.com>
Date: Jun 24 2020 07:45:01 +0000
Subject: PR#2237: db: use timestamps with timezone


Merges #2237
https://pagure.io/koji/pull-request/2237

Fixes: #2160
https://pagure.io/koji/issue/2160
event times subject to postgres timezone setting

---

diff --git a/docs/schema-upgrade-1.21-1.22.sql b/docs/schema-upgrade-1.21-1.22.sql
new file mode 100644
index 0000000..f588e49
--- /dev/null
+++ b/docs/schema-upgrade-1.21-1.22.sql
@@ -0,0 +1,31 @@
+-- upgrade script to migrate the Koji database schema
+-- from version 1.20 to 1.21
+
+
+BEGIN;
+
+ALTER TABLE events ALTER COLUMN time TYPE TIMESTAMPTZ USING
+    timezone(current_setting('TIMEZONE'), time::timestamptz);
+ALTER TABLE sessions ALTER COLUMN start_time TYPE TIMESTAMPTZ USING
+    timezone(current_setting('TIMEZONE'), start_time::timestamptz);
+ALTER TABLE sessions ALTER COLUMN update_time TYPE TIMESTAMPTZ USING
+    timezone(current_setting('TIMEZONE'), update_time::timestamptz);
+ALTER TABLE task ALTER COLUMN create_time TYPE TIMESTAMPTZ USING
+    timezone(current_setting('TIMEZONE'), create_time::timestamptz);
+ALTER TABLE task ALTER COLUMN start_time TYPE TIMESTAMPTZ USING
+    timezone(current_setting('TIMEZONE'), start_time::timestamptz);
+ALTER TABLE task ALTER COLUMN completion_time TYPE TIMESTAMPTZ USING
+    timezone(current_setting('TIMEZONE'), completion_time::timestamptz);
+ALTER TABLE build ALTER COLUMN start_time TYPE TIMESTAMPTZ USING
+    timezone(current_setting('TIMEZONE'), start_time::timestamptz);
+ALTER TABLE build ALTER COLUMN completion_time TYPE TIMESTAMPTZ USING
+    timezone(current_setting('TIMEZONE'), completion_time::timestamptz);
+ALTER TABLE build_reservations ALTER COLUMN created TYPE TIMESTAMPTZ USING
+    timezone(current_setting('TIMEZONE'), created::timestamptz);
+
+DROP FUNCTION IF EXISTS get_event_time;
+CREATE FUNCTION get_event_time(INTEGER) RETURNS TIMESTAMPTZ AS '
+	SELECT time FROM events WHERE id=$1;
+' LANGUAGE SQL;
+
+COMMIT;
diff --git a/docs/schema.sql b/docs/schema.sql
index dc0d38f..725f4be 100644
--- a/docs/schema.sql
+++ b/docs/schema.sql
@@ -7,7 +7,7 @@ BEGIN WORK;
 -- in the event that the system clock rolls back, event_ids will retain proper sequencing
 CREATE TABLE events (
 	id SERIAL NOT NULL PRIMARY KEY,
-	time TIMESTAMP NOT NULL DEFAULT clock_timestamp()
+	time TIMESTAMPTZ NOT NULL DEFAULT clock_timestamp()
 ) WITHOUT OIDS;
 
 -- A function that creates an event and returns the id, used as DEFAULT value for versioned tables
@@ -18,7 +18,7 @@ CREATE FUNCTION get_event() RETURNS INTEGER AS '
 
 -- A convenience function for converting events to timestamps, useful for
 -- quick queries where you want to avoid JOINs.
-CREATE FUNCTION get_event_time(INTEGER) RETURNS TIMESTAMP AS '
+CREATE FUNCTION get_event_time(INTEGER) RETURNS TIMESTAMPTZ AS '
 	SELECT time FROM events WHERE id=$1;
 ' LANGUAGE SQL;
 
@@ -116,8 +116,8 @@ CREATE TABLE sessions (
 	authtype INTEGER,
 	hostip VARCHAR(255),
 	callnum INTEGER,
-	start_time TIMESTAMP NOT NULL DEFAULT NOW(),
-	update_time TIMESTAMP NOT NULL DEFAULT NOW(),
+	start_time TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+	update_time TIMESTAMPTZ NOT NULL DEFAULT NOW(),
 	exclusive BOOLEAN CHECK (exclusive),
 	CONSTRAINT no_exclusive_subsessions CHECK (
 		master IS NULL OR "exclusive" IS NULL),
@@ -213,9 +213,9 @@ CREATE TABLE host_channels (
 CREATE TABLE task (
 	id SERIAL NOT NULL PRIMARY KEY,
 	state INTEGER,
-	create_time TIMESTAMP NOT NULL DEFAULT NOW(),
-	start_time TIMESTAMP,
-	completion_time TIMESTAMP,
+	create_time TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+	start_time TIMESTAMPTZ,
+	completion_time TIMESTAMPTZ,
 	channel_id INTEGER NOT NULL REFERENCES channels(id),
 	host_id INTEGER REFERENCES host (id),
 	parent INTEGER REFERENCES task (id),
@@ -279,8 +279,8 @@ CREATE TABLE build (
 	epoch INTEGER,
 	source TEXT,
 	create_event INTEGER NOT NULL REFERENCES events(id) DEFAULT get_event(),
-	start_time TIMESTAMP,
-	completion_time TIMESTAMP,
+	start_time TIMESTAMPTZ,
+	completion_time TIMESTAMPTZ,
 	state INTEGER NOT NULL,
 	task_id INTEGER REFERENCES task (id),
 	owner INTEGER NOT NULL REFERENCES users (id),
@@ -518,7 +518,7 @@ CREATE TABLE cg_users (
 CREATE TABLE build_reservations (
 	build_id INTEGER NOT NULL REFERENCES build(id),
 	token VARCHAR(64),
-        created TIMESTAMP NOT NULL,
+        created TIMESTAMPTZ NOT NULL,
 	PRIMARY KEY (build_id)
 ) WITHOUT OIDS;
 CREATE INDEX build_reservations_created ON build_reservations(created);