From 178255803a41bc984ce86ba848013aaed9ad347c Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: May 15 2017 15:18:43 +0000 Subject: Only announce user's settings change if there was an error Signed-off-by: Pierre-Yves Chibon --- diff --git a/pagure/lib/__init__.py b/pagure/lib/__init__.py index f9dc342..7218373 100644 --- a/pagure/lib/__init__.py +++ b/pagure/lib/__init__.py @@ -1795,8 +1795,9 @@ def update_user_settings(session, settings, user): update.append(key) new_settings[key] = settings[key] else: - update.append(key) - new_settings[key] = False + if new_settings[key] != False: + update.append(key) + new_settings[key] = False if not update: return 'No settings to change' @@ -2012,6 +2013,7 @@ def search_projects( projects = projects.filter( model.Project.is_fork == False # noqa: E712 ) + if tags: if not isinstance(tags, (list, tuple)): tags = [tags]