From 99bda6f5c8d25cfe2550d48ac3a879eb3ff6668b Mon Sep 17 00:00:00 2001 From: Rafael Fontenelle Date: Jul 02 2020 21:57:07 +0000 Subject: Fix footnote link --- diff --git a/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc b/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc index 1de045a..f9618b2 100644 --- a/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc +++ b/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc @@ -50,7 +50,7 @@ There are many many things to check for a review. This list is provided to assis * *SHOULD*: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. footnote:[xref:LicensingGuidelines.adoc#_license_text[Licensing Guidelines: License Text\]] + * *SHOULD*: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. footnote:[xref:index.adoc#_summary_and_description[Packaging Guidelines: Summary and description\]] + * *SHOULD*: The reviewer should test that the package builds in mock. footnote:[https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds[Using Mock to test package builds\]] + -* *SHOULD*: The package should compile and build into binary rpms on all supported architectures. footnote:xref:index.adoc#_architecture_support[Packaging Guidelines: Architecture Support\]] + +* *SHOULD*: The package should compile and build into binary rpms on all supported architectures. footnote:[xref:index.adoc#_architecture_support[Packaging Guidelines: Architecture Support\]] + * *SHOULD*: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. + * *SHOULD*: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. footnote:[xref:index.adoc#_scriptlets[Packaging Guidelines: Scriptlets\]] + * *SHOULD*: Usually, subpackages other than devel should require the base package using a fully versioned dependency. footnote:[xref:index.adoc#_requiring_base_package[Packaging Guidelines: Requiring Base Package\]] +