From 16317fe5d0bc8350f4fae364612898d5773c84bd Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Jan 31 2018 12:38:38 +0000 Subject: Fix making the milestones showing in the correct order on the issue page Signed-off-by: Pierre-Yves Chibon --- diff --git a/pagure/ui/issues.py b/pagure/ui/issues.py index 46eda3f..e1eb86e 100644 --- a/pagure/ui/issues.py +++ b/pagure/ui/issues.py @@ -1042,7 +1042,7 @@ def view_issue(repo, issueid, username=None, namespace=None): status = pagure.lib.get_issue_statuses(flask.g.session) milestones = [] - for m in repo.milestones: + for m in repo.milestones_keys or repo.milestones: if repo.milestones[m]['active']: milestones.append(m) diff --git a/tests/test_pagure_flask_ui_repo_milestones.py b/tests/test_pagure_flask_ui_repo_milestones.py index 118bd64..f7cf01a 100644 --- a/tests/test_pagure_flask_ui_repo_milestones.py +++ b/tests/test_pagure_flask_ui_repo_milestones.py @@ -153,8 +153,9 @@ class PagureFlaskRepoMilestonestests(tests.Modeltests): @patch('pagure.decorators.admin_session_timedout', MagicMock(return_value=False)) - def test_issue_page_milestone_actives(self): - """ Test viewing tickets on a project having milestones, all active. + def test_issue_page_milestone_not_allactives(self): + """ Test viewing tickets on a project having milestones, not all + being active. """ repo = pagure.lib.get_authorized_project(self.session, 'test')