From b64b0aa69402e9f237565d4e9620a71ced051897 Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Sep 28 2018 08:30:22 +0000 Subject: Add a title to 'remove' dialog for details of 'Hosts' entity To improve translation quality the title of 'Remove' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7702 Reviewed-By: Serhii Tsymbaliuk Reviewed-By: Christian Heimes --- diff --git a/install/ui/src/freeipa/host.js b/install/ui/src/freeipa/host.js index 2d35700..f63cad4 100644 --- a/install/ui/src/freeipa/host.js +++ b/install/ui/src/freeipa/host.js @@ -404,36 +404,42 @@ return { $type: 'association', name: 'managedby_host', add_method: 'add_managedby', - remove_method: 'remove_managedby' + remove_method: 'remove_managedby', + remove_title: '@i18n:objects.host.remove_hosts_managing', }, { $type: 'association', name: 'memberof_hostgroup', - associator: IPA.serial_associator + associator: IPA.serial_associator, + remove_title: '@i18n:objects.host.remove_from_groups', }, { $type: 'association', name: 'memberof_netgroup', - associator: IPA.serial_associator + associator: IPA.serial_associator, + remove_title: '@i18n:objects.host.remove_from_netgroups', }, { $type: 'association', name: 'memberof_role', - associator: IPA.serial_associator + associator: IPA.serial_associator, + remove_title: '@i18n:objects.host.remove_from_roles', }, { $type: 'association', name: 'memberof_hbacrule', associator: IPA.serial_associator, add_method: 'add_host', - remove_method: 'remove_host' + remove_method: 'remove_host', + remove_title: '@i18n:objects.host.remove_from_hbac', }, { $type: 'association', name: 'memberof_sudorule', associator: IPA.serial_associator, add_method: 'add_host', - remove_method: 'remove_host' + remove_method: 'remove_host', + remove_title: '@i18n:objects.host.remove_from_sudo', } ], standard_association_facets: true, diff --git a/ipaserver/plugins/internal.py b/ipaserver/plugins/internal.py index 268f12a..13d47e1 100644 --- a/ipaserver/plugins/internal.py +++ b/ipaserver/plugins/internal.py @@ -687,6 +687,24 @@ class i18n_messages(Command): "password_set_success": _("OTP set"), "password_set_title": _("Set One-Time-Password"), "remove": _("Remove hosts"), + "remove_hosts_managing": _( + "Remove hosts managing host '${primary_key}'" + ), + "remove_from_groups": _( + "Remove host '${primary_key}' from host groups" + ), + "remove_from_netgroups": _( + "Remove host '${primary_key}' from netgroups" + ), + "remove_from_roles": _( + "Remove host '${primary_key}' from roles" + ), + "remove_from_hbac": _( + "Remove host '${primary_key}' from HBAC rules" + ), + "remove_from_sudo": _( + "Remove host '${primary_key}' from sudo rules" + ), "status": _("Status"), "unprovision": _("Unprovision"), "unprovision_confirmation": _("Are you sure you want to unprovision this host?"),