From 5720fd2da68b19b6a0b611076385364a9f16b884 Mon Sep 17 00:00:00 2001 From: Stanislav Ochotnicky Date: Dec 12 2013 10:15:54 +0000 Subject: [qa] Pass string formatting arguments to logging as args Don't format strings before passing to logging but let logging do it --- diff --git a/src/FedoraReview/helpers_mixin.py b/src/FedoraReview/helpers_mixin.py index 86f6865..5b75b89 100644 --- a/src/FedoraReview/helpers_mixin.py +++ b/src/FedoraReview/helpers_mixin.py @@ -121,8 +121,8 @@ class HelpersMixin(object): if p.returncode != 0: log = Settings.get_logger() log.debug("Cannot unpack " + archive) - log.debug("Status: %d, stdout: %s, stderr: %s." - % (p.returncode, str(stdout), str(stderr))) + log.debug("Status: %d, stdout: %s, stderr: %s.", + p.returncode, str(stdout), str(stderr)) return p.returncode == 0 @staticmethod