From 56d318aac1c917ab38a930aa471e90593b8c6484 Mon Sep 17 00:00:00 2001 From: Mike McLean Date: Jun 27 2017 16:58:15 +0000 Subject: another bad url for assert_allowed test --- diff --git a/tests/test_scm.py b/tests/test_scm.py index 4e013fd..bb65186 100644 --- a/tests/test_scm.py +++ b/tests/test_scm.py @@ -81,14 +81,19 @@ class TestSCM(unittest.TestCase): bad = [ "cvs://badserver/projects/42#ref", "svn://badserver/projects/42#ref", + "git://maybeserver/badpath/project#1234", ] for url in good: scm = SCM(url) scm.assert_allowed(allowed) for url in bad: scm = SCM(url) - with self.assertRaises(koji.BuildError): + try: scm.assert_allowed(allowed) + except koji.BuildError: + pass + else: + raise AssertionError("allowed bad url: %s" % url) @mock.patch('logging.getLogger') def test_badrule(self, getLogger):