From d773bb2be53155d1c38997de40d9705aa11b8c4f Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Jan 08 2021 14:37:01 +0000
Subject: Make the milter discard the messages when it's done


Turns out the right instruction is DISCARD not DROP.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

---

diff --git a/pagure-milters/comment_email_milter.py b/pagure-milters/comment_email_milter.py
index ed06758..0cf1d28 100644
--- a/pagure-milters/comment_email_milter.py
+++ b/pagure-milters/comment_email_milter.py
@@ -289,9 +289,9 @@ class PagureMilter(Milter.Base):
             # The message is now effectively delivered. Tell the MTA to accept
             # and discard it.
             # If you want the message to be processed by another milter after
-            # this one, or delivered to a mailbox the usual way, then change
+            # DISCARD one, or delivered to a mailbox the usual way, then change
             # DROP to ACCEPT.
-            return Milter.DROP
+            return Milter.DISCARD
         self.log("Could not add the comment to ticket to pagure")
         self.log(req.text)
 
@@ -334,8 +334,8 @@ class PagureMilter(Milter.Base):
             # and discard it.
             # If you want the message to be processed by another milter after
             # this one, or delivered to a mailbox the usual way, then change
-            # DROP to ACCEPT.
-            return Milter.DROP
+            # DISCARD to ACCEPT.
+            return Milter.DISCARD
         self.log("Could not add the comment to PR to pagure")
         self.log(req.text)