From a4e7a5aa467cad6132eb9d00170fd30f2856f4db Mon Sep 17 00:00:00 2001 From: Tomas Hrnciar Date: Jul 16 2019 11:12:46 +0000 Subject: [frontend] disallow project owner to build in group if is not member anymore fixes #843 --- diff --git a/frontend/coprs_frontend/coprs/models.py b/frontend/coprs_frontend/coprs/models.py index 5b8f9c0..7567137 100644 --- a/frontend/coprs_frontend/coprs/models.py +++ b/frontend/coprs_frontend/coprs/models.py @@ -117,18 +117,15 @@ class User(db.Model, helpers.Serializer): """ if copr.user.admin: return True - if copr.user_id == self.id: + if copr.group: + if self.can_build_in_group(copr.group): + return True + elif copr.user_id == self.id: return True if (self.permissions_for_copr(copr) and self.permissions_for_copr(copr).copr_builder == helpers.PermissionEnum("approved")): return True - - # a bit dirty code, here we access flask.session object - if copr.group is not None and \ - copr.group.fas_name in self.user_teams: - return True - return False @property