From 6fba9a81cdbacbbe92ca96377e15ff9898b2b3e9 Mon Sep 17 00:00:00 2001 From: Simon Pichugin Date: Mar 18 2020 20:27:08 +0000 Subject: Issue 50963 - We should bundle *.min.js files of Console Description: Currently, we do not bundle in the tarball the *.min.js files which help with deciphering the obfuscated code which is actually run by the browser. This leads to end-users submitting partially unreadable JavaScript stack traces. Please note this won't result in end-users having to download more data just to use the Console, since these files are downloaded only when needed, i.e. when Developer's Console is opened. https://pagure.io/389-ds-base/issue/50963 Reviewed by: mreynolds (Thanks!) --- diff --git a/rpm.mk b/rpm.mk index 75e1d64..02f5bba 100644 --- a/rpm.mk +++ b/rpm.mk @@ -54,7 +54,6 @@ install-node-modules: build-cockpit: install-node-modules cd src/cockpit/389-console; \ NODE_ENV=production make -f node_modules.mk build-cockpit-plugin - cd src/cockpit/389-console; rm -rf cockpit_dist/index.min.js.map dist-bz2: install-node-modules download-cargo-dependencies cd src/cockpit/389-console; \ @@ -64,7 +63,6 @@ dist-bz2: install-node-modules download-cargo-dependencies touch cockpit_dist/* mkdir -p $(NODE_MODULES_TEST) touch -r src/cockpit/389-console/package.json $(NODE_MODULES_TEST) - cd src/cockpit/389-console; rm -rf cockpit_dist/index.min.js.map tar cjf $(GIT_TAG).tar.bz2 --transform "s,^,$(GIT_TAG)/," $$(git ls-files) src/cockpit/389-console/cockpit_dist/ src/cockpit/389-console/node_modules cd src/cockpit/389-console; \ rm -rf node_modules; \