From bc47239c5c7e6d19564fcd2839c6f2bd81a5b540 Mon Sep 17 00:00:00 2001 From: Mark Reynolds Date: Dec 04 2014 21:12:09 +0000 Subject: Ticket 47969 - COS memory leak when rebuilding the cache Bug Description: When the COS cache is released, not all of the schema objectclasses are freed. So every time we rebuild the COS cache we leak memory. Fix Description: After we free the schema attributes, the very first attribute still needs to be freed. It is not freed initially because of the duplicate checking logic, so it is now done after the loop. https://fedorahosted.org/389/ticket/47969 Reviewed by: nhosoi(Thanks!) (cherry picked from commit d2dfda95c543f106443f898436151b00c68e4270) --- diff --git a/ldap/servers/plugins/cos/cos_cache.c b/ldap/servers/plugins/cos/cos_cache.c index a7993c8..fd163f9 100644 --- a/ldap/servers/plugins/cos/cos_cache.c +++ b/ldap/servers/plugins/cos/cos_cache.c @@ -1864,6 +1864,8 @@ static void cos_cache_del_schema(cosCache *pCache) } } } + /* Finally, remove the first attribute's objectclass list */ + cos_cache_del_attrval_list(&(pCache->ppAttrIndex[0]->pObjectclasses)); LDAPDebug( LDAP_DEBUG_TRACE, "<-- cos_cache_del_schema\n",0,0,0); }