From 144af5987dad38152e61f2e056ced3aa19eaa532 Mon Sep 17 00:00:00 2001 From: Rich Megginson Date: Feb 16 2012 15:55:19 +0000 Subject: coverity uninit var and resource leak 12550 Uninitialized pointer read In dna_update_config_event(): Reads an uninitialized pointer or its target 12549 Resource leak In referint_thread_func(): Leak of memory or pointers to system resources Reviewed by: mreynolds (Thanks!) --- diff --git a/ldap/servers/plugins/dna/dna.c b/ldap/servers/plugins/dna/dna.c index fedfa50..efb2de4 100644 --- a/ldap/servers/plugins/dna/dna.c +++ b/ldap/servers/plugins/dna/dna.c @@ -1271,7 +1271,7 @@ dna_load_host_port() static void dna_update_config_event(time_t event_time, void *arg) { - Slapi_PBlock *pb; + Slapi_PBlock *pb = NULL; struct configEntry *config_entry = NULL; PRCList *list = NULL; char *binddn = (char *)arg; diff --git a/ldap/servers/plugins/referint/referint.c b/ldap/servers/plugins/referint/referint.c index 775da59..ee7c781 100644 --- a/ldap/servers/plugins/referint/referint.c +++ b/ldap/servers/plugins/referint/referint.c @@ -920,6 +920,7 @@ referint_thread_func(void *arg) if(plugin_argv == NULL){ slapi_log_error( SLAPI_LOG_FATAL, REFERINT_PLUGIN_SUBSYSTEM, "referint_thread_func not get args \n" ); + slapi_pblock_destroy(pb); return; }