From 79b62ca87c0fb64ef17cde8c3ced5e9d78a3d657 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Dec 22 2016 10:52:08 +0000 Subject: Let's not forget to commit at the end of the transaction, it helps saving it --- diff --git a/pagure-logcom/pagure_logcom_server.py b/pagure-logcom/pagure_logcom_server.py index a3ec61d..c9ce468 100644 --- a/pagure-logcom/pagure_logcom_server.py +++ b/pagure-logcom/pagure_logcom_server.py @@ -73,7 +73,6 @@ def handle_messages(): namespace = data['project']['namespace'] session = pagure.lib.create_session(pagure.APP.config['DB_URL']) - print(session.bind.engine.url) LOG.info('Looking for project: %s%s of %s', '%s/' % namespacerepo if namespace else '', @@ -90,9 +89,14 @@ def handle_messages(): LOG.info('Processing %s commits in %s', len(commits), abspath) pagure.lib.git.log_commits_to_db( - pagure.SESSION, project, commits, abspath) - - session.close() + session, project, commits, abspath) + + try: + session.commit() + except SQLAlchemyError as err: # pragma: no cover + session.rollback() + finally: + session.close() LOG.info('Ready for another')