e9ce14a consolidate login waits, use postinstall not entrypoint for base

Authored and Committed by adamwill 7 years ago
38 files changed. 72 lines added. 122 lines removed.
lib/fedorabase.pm
file modified
+0 -13
lib/main_common.pm
file modified
+23 -1
main.pm
file modified
+5 -5
needles/console/text_console_login.json
file modified
+2 -1
needles/gnome/login_gdm.json
file modified
+1 -0
needles/kde/login_sddm-20160518.json
file modified
+2 -1
needles/kde/login_sddm-20160628.json
file removed
-24
needles/kde/login_sddm-20160628.png
file removed
-0
needles/kde/login_sddm-20160701_f24updated.json
file removed
-24
needles/kde/login_sddm-20160701_f24updated.png
file removed
-0
needles/kde/login_sddm-20160830.json
file modified
+2 -1
needles/kde/login_sddm.json
file modified
+3 -2
templates
file modified
+20 -7
tests/_console_wait_login.pm
file modified
+2 -1
tests/_graphical_wait_login.pm
file modified
+1 -5
tests/_support_server.pmtests/_support_server_postinstall.pm
file renamed
+0 -0
tests/base_selinux.pm
file modified
+0 -2
tests/base_service_manipulation.pm
file modified
+5 -6
tests/base_services_start.pm
file modified
+1 -8
tests/base_update_cli.pm
file modified
+0 -2
tests/database_client.pmtests/database_client_postinstall.pm
file renamed
+0 -0
tests/desktop_browser.pmtests/desktop_browser_postinstall.pm
file renamed
+0 -0
tests/desktop_notifications.pmtests/desktop_notifications_postinstall.pm
file renamed
+0 -0
tests/desktop_terminal.pmtests/desktop_terminal_postinstall.pm
file renamed
+0 -0
tests/desktop_update_graphical.pmtests/desktop_update_graphical_postinstall.pm
file renamed
+1 -1
tests/firewall_configured.pmtests/firewall_configured_postinstall.pm
file renamed
+0 -0
tests/firewall_disabled.pmtests/firewall_disabled_postinstall.pm
file renamed
+0 -0
tests/freeipa_client.pmtests/freeipa_client_postinstall.pm
file renamed
+0 -0
tests/freeipa_password_change.pmtests/freeipa_password_change_postinstall.pm
file renamed
+0 -0
tests/freeipa_webui.pmtests/freeipa_webui_postinstall.pm
file renamed
+0 -0
tests/realmd_join_cockpit.pmtests/realmd_join_cockpit_postinstall.pm
file renamed
+0 -0
tests/realmd_join_sssd.pmtests/realmd_join_sssd_postinstall.pm
file renamed
+0 -0
tests/role_deploy_database_server.pmtests/role_deploy_database_server_postinstall.pm
file renamed
+0 -0
tests/role_deploy_domain_controller.pm
file modified
+1 -5
tests/server_cockpit_basic.pmtests/server_cockpit_basic_postinstall.pm
file renamed
+0 -0
tests/server_cockpit_default.pmtests/server_cockpit_default_postinstall.pm
file renamed
+0 -0
tests/server_firewall_default.pmtests/server_firewall_default_postinstall.pm
file renamed
+0 -0
tests/upgrade_preinstall.pm
file modified
+3 -13
    consolidate login waits, use postinstall not entrypoint for base
    
    Summary:
    I started out wanting to fix an issue I noticed today where
    graphical upgrade tests were failing because they didn't wait
    for the graphical login screen properly; the test was sitting
    at the 'full Fedora logo' state of plymouth for a long time,
    so the current boot_to_login_screen's wait_still_screen was
    triggered by it and the function wound up failing on the
    assert_screen, because it was still some time before the real
    login screen appeared.
    
    So I tweaked the boot_to_login_screen implementation to work
    slightly differently (look for a login screen match, *then* -
    if we're dealing with a graphical login - wait_still_screen
    to defeat the 'old GPU buffer showing login screen' problem
    and assert the login screen again). But while working on it,
    I figured we really should consolidate all the various places
    that handle the bootloader -> login, we were doing it quite
    differently in all sorts of different places. And as part of
    that, I converted the base tests to use POSTINSTALL (and thus
    go through the shared _wait_login tests) instead of handling
    boot themselves. As part of *that*, I tweaked main.pm to not
    require all POSTINSTALL tests have the _postinstall suffix on
    their names, as it really doesn't make sense, and renamed the
    tests.
    
    Test Plan: Run all tests, see if they work.
    
    Reviewers: jskladan, garretraziel
    
    Reviewed By: garretraziel
    
    Subscribers: tflink
    
    Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
    
        
file modified
+0 -13
file modified
+23 -1
file modified
+5 -5
file modified
+1 -0
file modified
+3 -2
file modified
+20 -7
file modified
+2 -1
tests/_support_server.pm tests/_support_server_postinstall.pm
file renamed
file was renamed with no change to the file
file modified
+0 -2
file modified
+1 -8
file modified
+0 -2
tests/database_client.pm tests/database_client_postinstall.pm
file renamed
file was renamed with no change to the file
tests/desktop_browser.pm tests/desktop_browser_postinstall.pm
file renamed
file was renamed with no change to the file
tests/desktop_notifications.pm tests/desktop_notifications_postinstall.pm
file renamed
file was renamed with no change to the file
tests/desktop_terminal.pm tests/desktop_terminal_postinstall.pm
file renamed
file was renamed with no change to the file
tests/desktop_update_graphical.pm tests/desktop_update_graphical_postinstall.pm
file renamed
+1 -1
tests/firewall_configured.pm tests/firewall_configured_postinstall.pm
file renamed
file was renamed with no change to the file
tests/firewall_disabled.pm tests/firewall_disabled_postinstall.pm
file renamed
file was renamed with no change to the file
tests/freeipa_client.pm tests/freeipa_client_postinstall.pm
file renamed
file was renamed with no change to the file
tests/freeipa_password_change.pm tests/freeipa_password_change_postinstall.pm
file renamed
file was renamed with no change to the file
tests/freeipa_webui.pm tests/freeipa_webui_postinstall.pm
file renamed
file was renamed with no change to the file
tests/realmd_join_cockpit.pm tests/realmd_join_cockpit_postinstall.pm
file renamed
file was renamed with no change to the file
tests/realmd_join_sssd.pm tests/realmd_join_sssd_postinstall.pm
file renamed
file was renamed with no change to the file
tests/role_deploy_database_server.pm tests/role_deploy_database_server_postinstall.pm
file renamed
file was renamed with no change to the file
tests/server_cockpit_basic.pm tests/server_cockpit_basic_postinstall.pm
file renamed
file was renamed with no change to the file
tests/server_cockpit_default.pm tests/server_cockpit_default_postinstall.pm
file renamed
file was renamed with no change to the file
tests/server_firewall_default.pm tests/server_firewall_default_postinstall.pm
file renamed
file was renamed with no change to the file
file modified
+3 -13