From 4b5a16008d37293b9fef48f33b04334e324361c0 Mon Sep 17 00:00:00 2001 From: Tomas Kopecek Date: Apr 08 2020 10:48:51 +0000 Subject: revert main hub changes --- diff --git a/hub/kojihub.py b/hub/kojihub.py index 6b32e31..bdc435d 100644 --- a/hub/kojihub.py +++ b/hub/kojihub.py @@ -990,8 +990,7 @@ def _direct_pkglist_add(taginfo, pkginfo, owner, block, extra_arches, force, action = 'block' if policy: context.session.assertLogin() - policy_data = {'tag': tag_id, 'action': action, 'package': pkginfo, - 'force' : force, 'extra': tag['extra']} + policy_data = {'tag': tag_id, 'action': action, 'package': pkginfo, 'force': force} # don't check policy for admins using force if not (force and context.session.hasPerm('admin')): assert_policy('package_list', policy_data) @@ -1071,8 +1070,7 @@ def _direct_pkglist_remove(taginfo, pkginfo, force=False, policy=False): pkg = lookup_package(pkginfo, strict=True) if policy: context.session.assertLogin() - policy_data = {'tag': tag['id'], 'action': 'remove', 'package': pkg['id'], - 'force' : force, 'extra': tag['extra']} + policy_data = {'tag': tag['id'], 'action': 'remove', 'package': pkg['id'], 'force': force} # don't check policy for admins using force assert_policy('package_list', policy_data, force=force) @@ -1104,8 +1102,7 @@ def pkglist_unblock(taginfo, pkginfo, force=False): tag = get_tag(taginfo, strict=True) pkg = lookup_package(pkginfo, strict=True) context.session.assertLogin() - policy_data = {'tag': tag['id'], 'action': 'unblock', 'package': pkg['id'], - 'force' : force, 'extra': tag['extra']} + policy_data = {'tag': tag['id'], 'action': 'unblock', 'package': pkg['id'], 'force': force} # don't check policy for admins using force assert_policy('package_list', policy_data, force=force) user = get_user(context.session.user_id) diff --git a/tests/test_hub/test_pkglist.py b/tests/test_hub/test_pkglist.py index 7ab2642..8c8b18e 100644 --- a/tests/test_hub/test_pkglist.py +++ b/tests/test_hub/test_pkglist.py @@ -58,7 +58,7 @@ class TestPkglistBlock(unittest.TestCase): @mock.patch('kojihub.lookup_package') def test_pkglist_unblock(self, lookup_package, get_tag, assert_policy, readPackageList, _pkglist_add, _pkglist_remove): - tag = {'id': 1, 'name': 'tag', 'extra': {}} + tag = {'id': 1, 'name': 'tag'} pkg = {'id': 2, 'name': 'package', 'owner_id': 3} get_tag.return_value = tag lookup_package.return_value = pkg @@ -96,7 +96,7 @@ class TestPkglistBlock(unittest.TestCase): def test_pkglist_unblock_inherited(self, lookup_package, get_tag, assert_policy, readPackageList, _pkglist_add, _pkglist_remove): tag_id, pkg_id, owner_id = 1, 2, 3 - get_tag.return_value = {'id': tag_id, 'name': 'tag', 'extra': {}} + get_tag.return_value = {'id': tag_id, 'name': 'tag'} lookup_package.return_value = {'id': pkg_id, 'name': 'pkg'} readPackageList.return_value = {pkg_id: { 'blocked': True, @@ -123,7 +123,7 @@ class TestPkglistBlock(unittest.TestCase): def test_pkglist_unblock_not_present(self, lookup_package, get_tag, assert_policy, readPackageList, _pkglist_add, _pkglist_remove): tag_id, pkg_id = 1, 2 - get_tag.return_value = {'id': tag_id, 'name': 'tag', 'extra': {}} + get_tag.return_value = {'id': tag_id, 'name': 'tag'} lookup_package.return_value = {'id': pkg_id, 'name': 'pkg'} readPackageList.return_value = {} @@ -147,7 +147,7 @@ class TestPkglistBlock(unittest.TestCase): def test_pkglist_unblock_not_blocked(self, lookup_package, get_tag, assert_policy, readPackageList, _pkglist_add, _pkglist_remove): tag_id, pkg_id, owner_id = 1, 2, 3 - get_tag.return_value = {'id': tag_id, 'name': 'tag', 'extra': {}} + get_tag.return_value = {'id': tag_id, 'name': 'tag'} lookup_package.return_value = {'id': pkg_id, 'name': 'pkg'} readPackageList.return_value = {pkg_id: { 'blocked': False, @@ -200,7 +200,7 @@ class TestPkglistBlock(unittest.TestCase): force=False update=False policy=True - tag = {'id': 1, 'name': 'tag', 'extra': {}} + tag = {'id': 1, 'name': 'tag'} pkg = {'id': 2, 'name': 'pkg', 'owner_id': 3} users = [ {'id': 3, 'name': 'user'}, @@ -313,7 +313,7 @@ class TestPkglistBlock(unittest.TestCase): force=False update=False policy=True - tag = {'id': 1, 'name': 'tag', 'extra': {}} + tag = {'id': 1, 'name': 'tag'} pkg = {'id': 2, 'name': 'pkg', 'owner_id': 3} users = [ {'id': 3, 'name': 'user'}, @@ -370,7 +370,7 @@ class TestPkglistBlock(unittest.TestCase): force=False update=False policy=True - tag = {'id': 1, 'name': 'tag', 'extra': {}} + tag = {'id': 1, 'name': 'tag'} pkg = {'id': 2, 'name': 'pkg', 'owner_id': 3} users = [ {'id': 3, 'name': 'user',}, @@ -420,7 +420,7 @@ class TestPkglistBlock(unittest.TestCase): force=True update=False policy=True - tag = {'id': 1, 'name': 'tag', 'extra': {}} + tag = {'id': 1, 'name': 'tag'} pkg = {'id': 2, 'name': 'pkg', 'owner_id': 3} users = [ {'id': 3, 'name': 'user',},