jkaluza / freshmaker

Forked from freshmaker 7 years ago
Clone

7c8cdae Refactor "handlers" layout.

Authored and Committed by jkaluza 5 years ago
35 files changed. 310 lines added. 364 lines removed.
README.md
file modified
+2 -2
conf/config.py
file modified
+7 -9
freshmaker/handlers/internal/__init__.pyfreshmaker/handlers/bodhi/__init__.py
file renamed
+3 -1
freshmaker/handlers/internal/generate_advisory_signed_event_on_rpm_sign.pyfreshmaker/handlers/brew/sign_rpm.py
file renamed
+2 -2
freshmaker/handlers/internal/update_db_on_advisory_change.pyfreshmaker/handlers/errata/errata_advisory_state_changed.py
file renamed
+3 -3
freshmaker/handlers/internal/update_db_on_module_build.pyfreshmaker/handlers/mbs/module_state_change.py
file renamed
+2 -2
freshmaker/handlers/koji/__init__.py
file modified
+5 -1
freshmaker/handlers/koji/rebuild_images_on_git_dockerfile_change.pyfreshmaker/handlers/git/dockerfile_change.py
file renamed
+2 -2
freshmaker/handlers/koji/rebuild_images_on_odcs_compose_done.pyfreshmaker/handlers/odcs/compose_state_change.py
file renamed
+2 -2
freshmaker/handlers/koji/rebuild_images_on_parent_image_build.pyfreshmaker/handlers/brew/container_task_state_change.py
file renamed
+2 -2
freshmaker/handlers/koji/rebuild_images_on_rpm_advisory_change.pyfreshmaker/handlers/errata/errata_advisory_rpms_signed.py
file renamed
+2 -2
freshmaker/handlers/koji/rebuild_images_on_rpm_bodhi_update.pyfreshmaker/handlers/bodhi/update_complete_stable.py
file renamed
+2 -2
freshmaker/handlers/koji/task_state_change.py
file removed
-59
freshmaker/handlers/mbs/__init__.py
file modified
+2 -1
freshmaker/handlers/mbs/rebuild_modules_on_git_mmd_change.pyfreshmaker/handlers/git/module_metadata_change.py
file renamed
+2 -2
freshmaker/handlers/mbs/rebuild_modules_on_git_rpm_spec_change.pyfreshmaker/handlers/git/rpm_spec_change.py
file renamed
+2 -2
tests/handlers/__init__.pyfreshmaker/handlers/odcs/__init__.py
file renamed
+2 -2
tests/handlers/internal/__init__.pyfreshmaker/handlers/git/__init__.py
file renamed
+2 -4
tests/handlers/internal/test_generate_advisory_signed_event_on_rpm_sign.pytests/test_brew_sign_rpm_handler.py
file renamed
+17 -17
tests/handlers/internal/test_update_db_on_advisory_change.pytests/test_errata_advisory_state_changed.py
file renamed
+54 -54
tests/handlers/internal/test_update_db_on_module_build.pytests/test_mbs_module_state_change_handler.py
file renamed
+18 -18
tests/handlers/koji/__init__.pyfreshmaker/handlers/brew/__init__.py
file renamed
+3 -4
tests/handlers/koji/test_rebuild_images_on_git_dockerfile_change.pytests/test_git_dockerfile_change_handler.py
file renamed
+4 -4
tests/handlers/koji/test_rebuild_images_on_odcs_compose_done.pytests/test_odcs_compose_state_change.py
file renamed
+6 -6
tests/handlers/koji/test_rebuild_images_on_parent_image_build.pytests/test_brew_container_task_state_change_handler.py
file renamed
+6 -6
tests/handlers/koji/test_rebuild_images_on_rpm_advisory_change.pytests/test_errata_advisory_rpms_signed_handler.py
file renamed
+29 -29
tests/handlers/koji/test_rebuild_images_on_rpm_bodhi_update.pytests/test_bodhi_update_complete_stable_handler.py
file renamed
+14 -14
tests/handlers/mbs/__init__.pyfreshmaker/handlers/errata/__init__.py
file renamed
+3 -4
tests/handlers/mbs/test_rebuild_modules_on_git_mmd_change.pytests/test_git_module_metadata_change_handler.py
file renamed
+6 -6
tests/handlers/mbs/test_rebuild_modules_on_git_rpm_spec_change.pytests/test_git_rpm_spec_change_handler.py
file renamed
+10 -10
tests/test_config.py
file added
+36
tests/test_consumer.py
file modified
+2 -2
tests/test_koji_task_state_change_handler.py
file removed
-89
tests/test_monitor.py
file modified
+1 -1
tests/test_utils.py
file added
+57
    Refactor "handlers" layout.
    
    This commit changes the directory structure for Freshmaker handlers
    as well as their names. The reason is that the current structure
    presumes there is just single handler for each Freshmaker Event,
    but this will not be true for new features we are working on.
    
    It is also not clear from the handler's name what is the goal of
    the handler which makes the code harder to understand.
    
    In this commit, we change the layout and names like this:
    
      - Handlers are now grouped according to the main service which
        they use when handling the Event - for example handlers
        resulting in Koji builds use 'koji' directory. Handlers updating
        just the Freshmaker's internal DB uses 'internal' directory, ...
      - Handlers are now named like DoSomethingOnSomeEvent. This makes
        it clear what is the goal of a handler.
    
    For more information, you can read:
    
    https://docs.google.com/document/d/1dx6cuFblaZlf0BZtPU6kv-ZzNJgf2JHWQ-VfSDuHVyM/edit#
    
        
file modified
+2 -2
file modified
+7 -9
freshmaker/handlers/internal/__init__.py freshmaker/handlers/bodhi/__init__.py
file renamed
+3 -1
file renamed
+2 -2
freshmaker/handlers/internal/update_db_on_advisory_change.py freshmaker/handlers/errata/errata_advisory_state_changed.py
file renamed
+3 -3
freshmaker/handlers/internal/update_db_on_module_build.py freshmaker/handlers/mbs/module_state_change.py
file renamed
+2 -2
freshmaker/handlers/koji/rebuild_images_on_git_dockerfile_change.py freshmaker/handlers/git/dockerfile_change.py
file renamed
+2 -2
freshmaker/handlers/koji/rebuild_images_on_odcs_compose_done.py freshmaker/handlers/odcs/compose_state_change.py
file renamed
+2 -2
freshmaker/handlers/koji/rebuild_images_on_parent_image_build.py freshmaker/handlers/brew/container_task_state_change.py
file renamed
+2 -2
freshmaker/handlers/koji/rebuild_images_on_rpm_advisory_change.py freshmaker/handlers/errata/errata_advisory_rpms_signed.py
file renamed
+2 -2
freshmaker/handlers/koji/rebuild_images_on_rpm_bodhi_update.py freshmaker/handlers/bodhi/update_complete_stable.py
file renamed
+2 -2
freshmaker/handlers/mbs/rebuild_modules_on_git_mmd_change.py freshmaker/handlers/git/module_metadata_change.py
file renamed
+2 -2
freshmaker/handlers/mbs/rebuild_modules_on_git_rpm_spec_change.py freshmaker/handlers/git/rpm_spec_change.py
file renamed
+2 -2
tests/handlers/__init__.py freshmaker/handlers/odcs/__init__.py
file renamed
+2 -2
tests/handlers/internal/__init__.py freshmaker/handlers/git/__init__.py
file renamed
+2 -4
file renamed
+17 -17
tests/handlers/internal/test_update_db_on_advisory_change.py tests/test_errata_advisory_state_changed.py
file renamed
+54 -54
tests/handlers/internal/test_update_db_on_module_build.py tests/test_mbs_module_state_change_handler.py
file renamed
+18 -18
tests/handlers/koji/__init__.py freshmaker/handlers/brew/__init__.py
file renamed
+3 -4
tests/handlers/koji/test_rebuild_images_on_git_dockerfile_change.py tests/test_git_dockerfile_change_handler.py
file renamed
+4 -4
tests/handlers/koji/test_rebuild_images_on_odcs_compose_done.py tests/test_odcs_compose_state_change.py
file renamed
+6 -6
tests/handlers/koji/test_rebuild_images_on_parent_image_build.py tests/test_brew_container_task_state_change_handler.py
file renamed
+6 -6
tests/handlers/koji/test_rebuild_images_on_rpm_advisory_change.py tests/test_errata_advisory_rpms_signed_handler.py
file renamed
+29 -29
tests/handlers/koji/test_rebuild_images_on_rpm_bodhi_update.py tests/test_bodhi_update_complete_stable_handler.py
file renamed
+14 -14
tests/handlers/mbs/__init__.py freshmaker/handlers/errata/__init__.py
file renamed
+3 -4
tests/handlers/mbs/test_rebuild_modules_on_git_mmd_change.py tests/test_git_module_metadata_change_handler.py
file renamed
+6 -6
tests/handlers/mbs/test_rebuild_modules_on_git_rpm_spec_change.py tests/test_git_rpm_spec_change_handler.py
file renamed
+10 -10
file added
+36
file modified
+2 -2
file modified
+1 -1
file added
+57