From 782b5b177d49766350527fcba40191428644ca16 Mon Sep 17 00:00:00 2001 From: Chenxiong Qi Date: Dec 08 2017 04:22:58 +0000 Subject: Use SQLAlchemy false() instead of comparing with False Original code ``cls.released == False`` was detected by flake8 as an error E712: Comparison to False should be "if cond is False:" or "if not cond:". Signed-off-by: Chenxiong Qi --- diff --git a/freshmaker/models.py b/freshmaker/models.py index d5edc94..ca567b6 100644 --- a/freshmaker/models.py +++ b/freshmaker/models.py @@ -28,6 +28,7 @@ import json from datetime import datetime from sqlalchemy.orm import (validates, relationship) +from sqlalchemy.sql.expression import false from flask_login import UserMixin @@ -222,7 +223,7 @@ class Event(FreshmakerBase): state.value if isinstance(state, EventState) else state for state in states ] - return session.query(cls).filter(cls.released == False, + return session.query(cls).filter(cls.released == false(), cls.state.in_(states)).all() @property