From caf65ab23d1f446042baf3a6d6ac470c62357bb9 Mon Sep 17 00:00:00 2001 From: Nalin Dahyabhai Date: Jun 23 2015 21:31:11 +0000 Subject: Don't check a never-NULL pointer for being NULL Don't check that the state structure isn't NULL when we know it can't be, and doing so triggers a warning from static analysis. --- diff --git a/src/cadata.c b/src/cadata.c index 6c55c3c..2029df2 100644 --- a/src/cadata.c +++ b/src/cadata.c @@ -319,9 +319,7 @@ parse_certs(struct cm_store_ca *ca, struct cm_cadata_state *state, const char *p, *eom; int i; - if (state != NULL) { - state->modified = 0; - } + state->modified = 0; if (cm_json_decode(state, msg, -1, &json, &eom) != 0) { json = cm_json_new_object(state); /* Take the older-format data and build a JSON object out of