From 8e11a7972b1a0887e870be6c18dc07e67e7dd718 Mon Sep 17 00:00:00 2001 From: Vibhor Verma Date: Jan 18 2017 16:01:59 +0000 Subject: modify verb creation in PagureLog class --- diff --git a/pagure/lib/__init__.py b/pagure/lib/__init__.py index aa6b725..b3e33c3 100644 --- a/pagure/lib/__init__.py +++ b/pagure/lib/__init__.py @@ -1462,7 +1462,7 @@ def edit_issue(session, issue, ticketfolder, user, notify=False, notification=True, ) - log_action(session, status, issue, user_obj) + log_action(session, status.lower(), issue, user_obj) pagure.lib.notify.notify_status_change_issue(issue, user_obj) if not issue.private and edit: diff --git a/pagure/lib/model.py b/pagure/lib/model.py index 1f272c5..3d518ba 100644 --- a/pagure/lib/model.py +++ b/pagure/lib/model.py @@ -1838,24 +1838,23 @@ class PagureLog(BASE): 'project': self.project.fullname, } - if self.issue: - if self.log_type == 'created': - verb = 'created issue' - elif self.log_type == 'commented': - verb = 'comment on issue' - elif self.log_type == 'close': - verb = 'closed issue' - elif self.log_type == 'open': - verb = 'opened issue' - elif self.pull_request: - if self.log_type == 'created': - verb = 'created PR' - elif self.log_type == 'commented': - verb = 'comment on PR' - elif self.log_type == 'closed': - verb = 'closed PR' - elif self.log_type == 'merged': - verb = 'merged PR' + issue_verb={'created': 'created issue', + 'commented': 'commented on issue', + 'close': 'closed issue', + 'open': 'opened issue', + } + + pr_verb={'created': 'created PR', + 'commented': 'commented on PR', + 'close': 'closed PR', + 'open': 'opened PR', + 'merged': 'merged PR' + } + + if self.issue and self.log_type in issue_verb.keys(): + verb = issue_verb[self.log_type] + elif self.pull_request and self.log_type in pr_verb.keys(): + verb = pr_verb[self.log_type] elif not self.pull_request and not self.issue \ and self.log_type == 'created': verb = 'created Project'