From 85a53986e6da761787cc9f3a8c2d38204c0cac3e Mon Sep 17 00:00:00 2001 From: Nils Philippsen Date: Nov 28 2023 00:00:01 +0000 Subject: Don't refer to ansible-review anymore The upstream project seems pretty much dead, and it doesn't work with recent versions of ansible-lint. Signed-off-by: Nils Philippsen --- diff --git a/STYLEGUIDE b/STYLEGUIDE index 7a68630..bdbadd2 100644 --- a/STYLEGUIDE +++ b/STYLEGUIDE @@ -1,23 +1,16 @@ infrastructure ansible style guide ================================== -* run changes through 'ansible-review'. - ERRORs must be corrected or rules changed. - WARNs should be corrected. - - Rules changes can be proposed to - https://pagure.io/cpe/ansible-review-templates/ - -* Use 'yml' instead of 'yaml' +* Use 'yml' instead of 'yaml' * do add '.j2' to the end of templates -* in general let readablity trump grepability, ie: +* in general let readablity trump grepability, i.e.: DONT: - name: This is some play module: name=thing arg=thing2 anotherlongerarg=thing arg4=anodheranth - + DO: - name: This is some play module: