From d0ea261f84f9bf570bf0a380c73f4fb7039cb2ed Mon Sep 17 00:00:00 2001 From: Miro Hrončok Date: Feb 04 2022 18:13:23 +0000 Subject: The Python *Explicit lists* section now extends the general one --- diff --git a/guidelines/modules/ROOT/pages/Python.adoc b/guidelines/modules/ROOT/pages/Python.adoc index 3f31737..158fc8e 100644 --- a/guidelines/modules/ROOT/pages/Python.adoc +++ b/guidelines/modules/ROOT/pages/Python.adoc @@ -455,15 +455,16 @@ Packages *MUST NOT* own shared directories owned by Python itself, such as the top-level `+__pycache__+` directories (`+%{python3_sitelib}/__pycache__+`, `+%{python3_sitearch}/__pycache__+`). -Packagers *SHOULD NOT* simply glob everything under a shared directory. +Similarly to the xref:index#_explicit_lists[general rule], +packagers *SHOULD NOT* simply glob everything under a shared directory. -In particular, the following *SHOULD NOT* be used in `+%files+`: +In addition to the xref:index#_explicit_lists[general list], +the following *SHOULD NOT* be used in `+%files+`: * `+%{python3_sitelib}/*+` * `+%{python3_sitearch}/*+` * `+%{python_sitelib}/*+` * `+%{python_sitearch}/*+` -* `+%{_bindir}/*+` * `+%pyproject_save_files '*'+` * `+%pyproject_save_files +auto+` @@ -475,10 +476,9 @@ The most common mistakes this rule prevents are: * installing a test suite system-wide as an importable module named `+test+`, which would then conflict with other such packages, and -* upstream adding commands in `+%{_bindir}/*+` – +* upstream adding new unexpected importable modules – you should always check such changes for -https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_common_conflicting_files_cases_and_solutions[conflicts] -(especially with non-Python software), +https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_common_conflicting_files_cases_and_solutions[conflicts], and keep the list of such files explicit and auditable. == PyPI parity