From 19b244e3f3493acf020c75609dbc6875f5581ab1 Mon Sep 17 00:00:00 2001
From: Vivek Anand <vivekanand1101@gmail.com>
Date: Feb 15 2017 10:30:34 +0000
Subject: Adjust unit tests for ui/repo.py for project acls


Signed-off-by: Vivek Anand <vivekanand1101@gmail.com>

---

diff --git a/tests/test_pagure_flask_ui_repo.py b/tests/test_pagure_flask_ui_repo.py
index 816c0c3..9f50006 100644
--- a/tests/test_pagure_flask_ui_repo.py
+++ b/tests/test_pagure_flask_ui_repo.py
@@ -264,53 +264,47 @@ class PagureFlaskRepotests(tests.Modeltests):
                 'user': 'ralph',
             }
 
-            # Missing access
+            # Missing access and no CSRF
             output = self.app.post('/test/adduser', data=data)
             self.assertEqual(output.status_code, 200)
             self.assertIn(
                 '<title>Add user - test - Pagure</title>', output.data)
             self.assertTrue('<strong>Add user to the' in output.data)
 
-            data['csrf_token'] = csrf_token
+            # No CSRF
             output = self.app.post('/test/adduser', data=data)
             self.assertEqual(output.status_code, 200)
             self.assertIn(
                 '<title>Add user - test - Pagure</title>', output.data)
-            self.assertIn('<strong>Add user to the', output.data)
 
-            data = {
-                'user': 'ralph',
-                'access': 'commit',
-            }
-
-            # No CSRF
+            # Missing access
+            data['csrf_token'] = csrf_token
             output = self.app.post('/test/adduser', data=data)
             self.assertEqual(output.status_code, 200)
             self.assertIn(
                 '<title>Add user - test - Pagure</title>', output.data)
+            self.assertIn('<strong>Add user to the', output.data)
 
             # Unknown user
-            data['csrf_token'] = csrf_token
+            data['access'] = 'commit'
             output = self.app.post('/test/adduser', data=data)
             self.assertEqual(output.status_code, 200)
             self.assertIn(
                 '<title>Add user - test - Pagure</title>', output.data)
             self.assertIn('<strong>Add user to the', output.data)
             self.assertIn(
-                '</button>\n                      No user &#34;ralph&#34; '
-                'found', output.data)
+                '</button>\n                      No user &#34;ralph&#34; found\n',
+                output.data)
 
+            # All correct
             data['user'] = 'foo'
             output = self.app.post(
                 '/test/adduser', data=data, follow_redirects=True)
             self.assertEqual(output.status_code, 200)
-            self.assertIn(
-                '<title>Settings - test - Pagure</title>', output.data)
             self.assertIn('<h3>Settings for test</h3>', output.data)
             self.assertIn(
                 '</button>\n                      User added', output.data)
 
-
     @patch('pagure.ui.repo.admin_session_timedout')
     def test_add_group_project_when_user_mngt_off(self, ast):
         """ Test the add_group_project endpoint  when user management is