From ee9bfb0a2a646cd60eb36406f8b519a587252e2d Mon Sep 17 00:00:00 2001 From: Robert-André Mauchin Date: Mar 12 2019 00:13:03 +0000 Subject: Fix detection of pkg suffixes to ignore The current code does not work as expected. It should be a if construction and not a for loop. The previous patch I had made for it is likely to have been badly commited. --- diff --git a/plugins/generic_should.py b/plugins/generic_should.py index 3734a55..6a3ef36 100644 --- a/plugins/generic_should.py +++ b/plugins/generic_should.py @@ -264,7 +264,7 @@ class CheckFullVerReqSub(GenericShouldCheckBase): for pkg in self.spec.packages: if pkg == self.spec.base_package: continue - for pkg_end in ['debuginfo', 'debugsource', '-javadoc', '-doc']: + if pkg.endswith(('debuginfo', 'debugsource', '-javadoc', '-doc')): continue reqs = ''.join(self.rpms.get(pkg).format_requires) if regex not in reqs: