From e7da05901f7eab508dc373e75221db5cb7855294 Mon Sep 17 00:00:00 2001 From: Matthew Krupcale Date: Nov 20 2019 11:26:03 +0000 Subject: Use `sort_key` attribute for sorting checks in `--display-checks` Previously, errors such as TypeError: '<' not supported between instances of 'RCheckCheckMacro' and 'RCheckBuildRequires' would result from trying to sort the check classes directly, which don't implement the `__lt__` method for sorting. This fix uses the `sort_key` attribute inherited from `AbstractCheck` to sort the checks. * src/FedoraReview/review_helper.py: Use `sort_key` attribute for sorting checks --- diff --git a/src/FedoraReview/review_helper.py b/src/FedoraReview/review_helper.py index bea10b5..1c5ca77 100644 --- a/src/FedoraReview/review_helper.py +++ b/src/FedoraReview/review_helper.py @@ -158,7 +158,7 @@ class ReviewHelper(object): if checks == []: continue print("Group: " + group) - for c in sorted(checks): + for c in sorted(checks, key=lambda c: int(c.sort_key)): print(" {}: {}".format(c.name, c.text)) print()