From 999139017f1b1beb4ce7c5b15d7364f779eaedba Mon Sep 17 00:00:00 2001 From: Alec Leamas Date: Sep 18 2012 13:17:48 +0000 Subject: spec_file.find_all(): handle skip_changelog better (#141) --- diff --git a/src/FedoraReview/spec_file.py b/src/FedoraReview/spec_file.py index f71a063..78ffd16 100644 --- a/src/FedoraReview/spec_file.py +++ b/src/FedoraReview/spec_file.py @@ -230,13 +230,10 @@ class SpecFile(object): def find_all(self, regex, skip_changelog=False): ''' Find all non-changelog lines matching regex. ''' - my_lines = list(self.lines) - if skip_changelog: - line = my_lines.pop() - while not '%changelog' in line.lower() and my_lines: - line = my_lines.pop() - result = [] - for line in my_lines: + for line in self.lines: + if skip_changelog: + if line.lower().strip().startswith('%changelog'): + break res = regex.search(line) if res: result.append(res)