From 98a58306a7583d42a1a5d995783e102016cc461b Mon Sep 17 00:00:00 2001
From: Matthew Krupcale <mkrupcale@matthewkrupcale.com>
Date: Nov 05 2019 15:39:17 +0000
Subject: Handle `SystemExit` error separately from `BaseException`


Previously, running `fedora-review` with no arguments or just `--help` would result in `ERROR: Exception down the road...` due to Python ArgumentParser invoking `sys.exit()`, which raises `SystemExit`, which is a `BaseException`. This is not really an error in this case, though, so it's somewhat misleading to the user.

 * src/FedoraReview/review_helper.py: Handle `SystemExit` error separately from `BaseException`

---

diff --git a/src/FedoraReview/review_helper.py b/src/FedoraReview/review_helper.py
index 30a8db0..bea10b5 100644
--- a/src/FedoraReview/review_helper.py
+++ b/src/FedoraReview/review_helper.py
@@ -248,6 +248,8 @@ class ReviewHelper(object):
                     msg += " (logs in " + Settings.session_log + ")"
                 self.log.error(msg)
             rcode = err.exitcode
+        except SystemExit:
+            pass
         except BaseException:
             self.log.debug("Exception down the road...", exc_info=True)
             self.log.error(