From 4d49d07aee2e850783526bc71c81d54f6ff3e852 Mon Sep 17 00:00:00 2001
From: Alec Leamas <alec@tests.notat.diaspora.com>
Date: Sep 18 2012 22:05:24 +0000
Subject: Fixing crash when macro in url (#138)


Expand url before using it. Also patch-of-patch for #141, which was
badly broken after last commit

---

diff --git a/src/FedoraReview/spec_file.py b/src/FedoraReview/spec_file.py
index 78ffd16..2daf1f8 100644
--- a/src/FedoraReview/spec_file.py
+++ b/src/FedoraReview/spec_file.py
@@ -71,7 +71,7 @@ class SpecFile(object):
             if _type != srctype:
                 continue
             tag = srctype + str(num)
-            result[tag] = url
+            result[tag] = self.spec_obj.sourceHeader.format(url)
         return result
 
     def has_patches(self):
@@ -230,6 +230,7 @@ class SpecFile(object):
 
     def find_all(self, regex, skip_changelog=False):
         ''' Find all non-changelog lines matching regex. '''
+        result = []
         for line in self.lines:
             if skip_changelog:
                 if line.lower().strip().startswith('%changelog'):