From 06fae3b5e432f8be786000d1bdc1de1ee6594e3d Mon Sep 17 00:00:00 2001 From: Miro HronĨok Date: Mar 14 2019 14:19:34 +0000 Subject: Avoid unnecessary list construction --- diff --git a/src/FedoraReview/checks.py b/src/FedoraReview/checks.py index c399a0f..1318d19 100644 --- a/src/FedoraReview/checks.py +++ b/src/FedoraReview/checks.py @@ -326,8 +326,8 @@ class Checks(_ChecksLoader): def _get_ready_to_run(self): ''' Return checks ready to run, deprecating checks first. ''' - names = list(self.checkdict.keys()) - tests_to_run = [n for n in names if self._ready_to_run(n)] + names = self.checkdict.keys() + tests_to_run = (n for n in names if self._ready_to_run(n)) return sorted(tests_to_run, key=lambda t: len(self.checkdict[t].deprecates), reverse=True)