From 77ab2e8dd0b052af49b975d22f472828d0b6f531 Mon Sep 17 00:00:00 2001 From: Jason Tibbitts Date: Jan 14 2014 21:00:45 +0000 Subject: Handle change requests for nonexistent packages Try to handle the case where we get a change request for a package that does not exist in pkgdb. Gives more complaints than necessary but at least doesn't backtrace. --- diff --git a/scripts/process-git-requests/process-git-requests b/scripts/process-git-requests/process-git-requests index 2abaa01..47b68b1 100755 --- a/scripts/process-git-requests/process-git-requests +++ b/scripts/process-git-requests/process-git-requests @@ -350,7 +350,12 @@ def change_request_string(items, bug): def get_pkgdb_owners(pkgdb, pkg): owners = {} o = '' - for i in pkgdb.get_owners(pkg)['packageListings']: + try: + ownerlist = pkgdb.get_owners(pkg)['packageListings'] + except AppError, e: + return(owners, o) + + for i in ownerlist: branch = i['collection']['branchname'] if branch not in branches: continue @@ -550,6 +555,8 @@ def process_change_request(bug, comment, allcomments, firstfound, pkgdb, branche (owners, owner_string) = get_pkgdb_owners(pkgdb, items['Package Name']) # Try to enforce EPEL branch rules + if not len(owners): + warnings.append("WARNING: Package does not appear to exist in pkgdb currently.") for i in owners.keys(): if request['owner'] == owners[i]['primary'] or request['owner'] in owners[i]['comaint']: owned = True