From f9a00bc95bef31c6dcd77fb202bfde75c94ed186 Mon Sep 17 00:00:00 2001 From: Otto Urpelainen Date: Sep 06 2021 20:04:37 +0000 Subject: Remove specfile translation review item The Review Guidelines item about specfile description and summary translations is not supported by anything in the Packaging Guidelines. Given footnote only says that such translations can be included. Since the Packaging Guidelines do not express any preference for either including or omitting such translations, there is not for the reviewer to check. --- diff --git a/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc b/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc index 9a00852..92aa741 100644 --- a/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc +++ b/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc @@ -49,7 +49,6 @@ There are many many things to check for a review. This list is provided to assis ''' * *SHOULD*: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. footnote:[xref:LicensingGuidelines.adoc#_license_text[Licensing Guidelines: License Text\]] + -* *SHOULD*: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. footnote:[xref:index.adoc#_summary_and_description[Packaging Guidelines: Summary and description\]] + * *SHOULD*: The reviewer should test that the package builds in mock. footnote:[https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds[Using Mock to test package builds\]] + * *SHOULD*: The package should compile and build into binary rpms on all supported architectures. footnote:[xref:index.adoc#_architecture_support[Packaging Guidelines: Architecture Support\]] + * *SHOULD*: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. +