From 17216738d41a43764c76a50ade8db06b4659cc8d Mon Sep 17 00:00:00 2001
From: Vivek Anand <vivekanand1101@gmail.com>
Date: Feb 28 2017 11:09:08 +0000
Subject: lib/login.py: remove get_users_by_group


This function was never used and we do have
a backref in model.User to access the users
from groups. Hence, removing it.

---

diff --git a/pagure/lib/login.py b/pagure/lib/login.py
index 4227c94..b821e20 100644
--- a/pagure/lib/login.py
+++ b/pagure/lib/login.py
@@ -48,27 +48,6 @@ def get_session_by_visitkey(session, sessionid):
     return query.first()
 
 
-def get_users_by_group(session, group):
-    ''' Return the list of users for a specified group.
-
-    :arg session: the session with which to connect to the database.
-
-    '''
-    query = session.query(
-        model.User
-    ).filter(
-        model.User.id == model.PagureUserGroup.user_id
-    ).filter(
-        model.PagureUserGroup.group_id == model.PagureGroup.id
-    ).filter(
-        model.PagureGroup.group_name == group
-    ).order_by(
-        model.User.user
-    )
-
-    return query.all()
-
-
 def generate_hashed_value(password):
     """ Generate hash value for password
     """
diff --git a/tests/test_pagure_lib_login.py b/tests/test_pagure_lib_login.py
index ae1ca5d..935b0e5 100644
--- a/tests/test_pagure_lib_login.py
+++ b/tests/test_pagure_lib_login.py
@@ -40,12 +40,6 @@ class PagureLibLogintests(tests.Modeltests):
             'aaa'
         )
 
-    def test_get_users_by_group(self):
-        ''' Test pagure.lib.login.get_users_by_group. '''
-
-        users = pagure.lib.login.get_users_by_group(self.session, 'foo')
-        self.assertEqual(users, [])
-
     def test_get_session_by_visitkey(self):
         ''' Test pagure.lib.login.get_session_by_visitkey. '''