From fcfceb286d0743e93b242e1feaae11a42938e077 Mon Sep 17 00:00:00 2001 From: Noriko Hosoi Date: Feb 28 2015 01:57:34 +0000 Subject: Ticket #48048 - Fix coverity issues - 2015/2/24 Coverity defect 13071 - Explicit null dereferenced (FORWARD_NULL) Description: Added NULL check for mrINDEX. modified: matchrule_values_to_keys in matchrule.c --- diff --git a/ldap/servers/slapd/back-ldbm/matchrule.c b/ldap/servers/slapd/back-ldbm/matchrule.c index 7af42f4..6de6461 100644 --- a/ldap/servers/slapd/back-ldbm/matchrule.c +++ b/ldap/servers/slapd/back-ldbm/matchrule.c @@ -155,9 +155,13 @@ matchrule_values_to_keys(Slapi_PBlock *pb,struct berval **input_values,struct be slapi_pblock_get (pb, SLAPI_PLUGIN_MR_INDEX_FN, &mrINDEX); slapi_pblock_set (pb, SLAPI_PLUGIN_MR_VALUES, input_values); - mrINDEX (pb); - slapi_pblock_get (pb, SLAPI_PLUGIN_MR_KEYS, output_values); - return 0; + if (mrINDEX) { + mrINDEX (pb); + slapi_pblock_get (pb, SLAPI_PLUGIN_MR_KEYS, output_values); + return LDAP_SUCCESS; + } else { + return LDAP_OPERATIONS_ERROR; + } } /*