From 9c33372b1c8eb7e7c876d7389b0af1c77c46653e Mon Sep 17 00:00:00 2001 From: Noriko Hosoi Date: Feb 28 2015 01:57:35 +0000 Subject: Ticket #48048 - Fix coverity issues - 2015/2/24 Coverity defect 13053 - Explicit null dereferenced (FORWARD_NULL) Description: Added NULL check for sdn. modified: chaining_back_compare in cb_compare.c --- diff --git a/ldap/servers/plugins/chainingdb/cb_compare.c b/ldap/servers/plugins/chainingdb/cb_compare.c index 594c4bb..6907c42 100644 --- a/ldap/servers/plugins/chainingdb/cb_compare.c +++ b/ldap/servers/plugins/chainingdb/cb_compare.c @@ -85,10 +85,13 @@ chaining_back_compare ( Slapi_PBlock *pb ) return -1; } - slapi_pblock_get( pb, SLAPI_COMPARE_TARGET_SDN, &sdn ); slapi_pblock_get( pb, SLAPI_COMPARE_TYPE, &type ); slapi_pblock_get( pb, SLAPI_COMPARE_VALUE, &bval ); - + slapi_pblock_get( pb, SLAPI_COMPARE_TARGET_SDN, &sdn ); + if (NULL == sdn) { + cb_send_ldap_result(pb, LDAP_INVALID_DN_SYNTAX, NULL, "Null target DN", 0, NULL ); + return -1; + } dn = slapi_sdn_get_dn(sdn); /*