cgrzemba / 389-ds-base

Forked from 389-ds-base 5 years ago
Clone

3561044 Bug 634561 - Server crushes when using Windows Sync Agreement

Authored and Committed by rmeggins 13 years ago
    Bug 634561 - Server crushes when using Windows Sync Agreement
    
    https://bugzilla.redhat.com/show_bug.cgi?id=634561
    Resolves: bug 634561
    Bug Description: Server crushes when using Windows Sync Agreement
    Reviewed by: ???
    Branch: master
    Fix Description: The regular replication protocol and the windows sync
    protocol have two completely different struct repl_connection.  They
    are almost the same, almost identical fields, but they are different.
    When additional fields were added to the struct repl_connection, not
    at the end of the structure, and identical changes were not made to the
    struct repl_connection in windows_connection.c, the structures got out
    of sync.  The authors tried to anticipate this condition by providing
    windows_ versions of all of the conn_ functions.  We were not using the
    windows_ versions of these functions in all places in the winsync code.
    The fix is to use the windows_ versions of these functions throughout
    the winsync code, and to make the struct repl_connection the same size
    up through the char *plain field.  If additional fields are added to
    either structure at the end, this problem should not occur in the
    future.
    Platforms tested: RHEL5 x86_64
    Flag Day: no
    Doc impact: no
    (cherry picked from commit 4bd78323d0bb1299a19e0ed1feebc79ff997c92f)