From b873ef03bb7457ab0f576ff159fac803cf0eb89a Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Jan 09 2017 11:20:47 +0000
Subject: Allow setting the assignee to None but just discard any un-interested messages


As mentioned before, the 'Nothing changed' message is sent just by this
method, so if another method changed something, we end up with two
messages one saying 'Nothing changed' and the other saying that something
did change. Not nice.
This fixes it.

---

diff --git a/pagure/ui/issues.py b/pagure/ui/issues.py
index e91573d..4ce8d5d 100644
--- a/pagure/ui/issues.py
+++ b/pagure/ui/issues.py
@@ -241,17 +241,16 @@ def update_issue(repo, issueid, username=None, namespace=None):
             # other fields will be missing for non-admin and thus reset if we let them
             if repo_admin:
                 # Assign or update assignee of the ticket
-                if assignee:
-                    message = pagure.lib.add_issue_assignee(
-                        SESSION,
-                        issue=issue,
-                        assignee=assignee or None,
-                        user=flask.g.fas_user.username,
-                        ticketfolder=APP.config['TICKETS_FOLDER'],
-                    )
-                    SESSION.commit()
-                    if message:
-                        messages.add(message)
+                message = pagure.lib.add_issue_assignee(
+                    SESSION,
+                    issue=issue,
+                    assignee=assignee or None,
+                    user=flask.g.fas_user.username,
+                    ticketfolder=APP.config['TICKETS_FOLDER'],
+                )
+                SESSION.commit()
+                if message and message != 'Nothing to change':
+                    messages.add(message)
 
                 # Update priority
                 if str(new_priority) in repo.priorities: