From cc79e327dc74e615e3c008a811c09950c79b645c Mon Sep 17 00:00:00 2001
From: Pavel Raiskup <praiskup@redhat.com>
Date: Nov 16 2020 15:02:20 +0000
Subject: dnf-automatic: disable the makecache timer, not the service


Service can be unmasked, as long as nobody triggers it.  If we do it the
other way arount, we see this every-time we log-in on F33+:

    Last login: Fri Nov 13 09:15:56 2020 from 193.165.237.101
    [systemd]
    Failed Units: 1
      dnf-makecache.timer

Which is:

    systemctl status dnf-makecache.timer
    ...
    ...: dnf-makecache.timer: Failed to queue unit startup job: Unit dnf-makecache.service is masked.
    ...: dnf-makecache.timer: Failed with result 'resources'.

---

diff --git a/roles/dnf-automatic/tasks/main.yml b/roles/dnf-automatic/tasks/main.yml
index 3e63370..bab0887 100644
--- a/roles/dnf-automatic/tasks/main.yml
+++ b/roles/dnf-automatic/tasks/main.yml
@@ -83,7 +83,7 @@
     when: automaticative is failed and ansible_distribution_major_version|int >= 29 and ansible_distribution == 'Fedora'
 
   - name: disable silly makecache timer
-    systemd: name=dnf-makecache masked=yes
+    systemd: name=dnf-makecache.timer masked=yes
     ignore_errors: true
 
   when: ansible_pkg_mgr == 'dnf'