From caaec729b7f3c43598beb30016250324c737134b Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Jan 13 2021 08:54:07 +0000 Subject: Drop the user_notifications configuration key That key was present only in the tests and not used anywhere else in the code. The toddler distgit-bugzilla-sync does not warn any user that their account are incorrectly set-up. This is achived by the toddler: packager-without-bugzilla which runs daily. Signed-off-by: Pierre-Yves Chibon --- diff --git a/tests/plugins/test_distgit_bugzilla_sync.py b/tests/plugins/test_distgit_bugzilla_sync.py index 1884a7c..5f09235 100644 --- a/tests/plugins/test_distgit_bugzilla_sync.py +++ b/tests/plugins/test_distgit_bugzilla_sync.py @@ -25,7 +25,6 @@ def config(): "server": "https://pdc.fedoraproject.org/rest_api/v1", }, # distgit_bugzilla_sync config values - "user_notifications": False, "ignorable_accounts": [], "fasjson": False, "default_qa_contact": "nurgle@fedoraproject.org", @@ -510,7 +509,6 @@ class TestDistgitBugzillaSyncToddler: """Assert that `xmlrpc.client.ProtocolError` is reported correctly.""" # Adjust config config["temp_folder"] = tmpdir - config["user_notifications"] = True # Mock toml load email_overrides = Mock() mock_toml.return_value = email_overrides @@ -624,7 +622,6 @@ class TestDistgitBugzillaSyncToddler: """Assert that `xmlrpc.client.Error` is reported correctly.""" # Adjust config config["temp_folder"] = tmpdir - config["user_notifications"] = True # Mock toml load email_overrides = Mock() mock_toml.return_value = email_overrides @@ -1270,7 +1267,6 @@ class TestDistgitBugzillaSyncToddler: """Assert that user_cache is used if exists.""" # Adjust config config["temp_folder"] = tmpdir - config["user_notifications"] = True # Prepare user cache data = {