From ac324bd42d0a41c05f31eb5e866404e504ec5fbf Mon Sep 17 00:00:00 2001 From: Yu Ming Zhu Date: May 20 2021 17:58:01 +0000 Subject: koji-ssl-admin: fix the signature for cryptography.x509.*Builder().add_extension() The 1st argument has been changed from `extension` to `extval`. --- diff --git a/src/bin/koji-ssl-admin b/src/bin/koji-ssl-admin index c76be1c..f3e5608 100755 --- a/src/bin/koji-ssl-admin +++ b/src/bin/koji-ssl-admin @@ -197,7 +197,7 @@ def generate_ca(key, path, name, force=False): x509.BasicConstraints(ca=True, path_length=0), critical=True, ) builder = builder.add_extension( - extension=x509.KeyUsage( + x509.KeyUsage( digital_signature=True, key_encipherment=False, content_commitment=False, @@ -260,7 +260,7 @@ def sign_with_ca(csr_path, ca_key_path, ca_crt_path, crt_path, force=False): builder = builder.not_valid_before(datetime.utcnow()) builder = builder.not_valid_after(in_two_years) builder = builder.add_extension( - extension=x509.KeyUsage( + x509.KeyUsage( digital_signature=True, key_encipherment=True, content_commitment=True,