From 69e327b66f0a5b81f32fdfa0b1708e2fe6d3dc4b Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Aug 18 2020 11:48:34 +0000 Subject: Fix appending an element to a list rather than trying to call the list Signed-off-by: Pierre-Yves Chibon --- diff --git a/monitor_gating/utils.py b/monitor_gating/utils.py index 210282f..68f6332 100644 --- a/monitor_gating/utils.py +++ b/monitor_gating/utils.py @@ -156,7 +156,7 @@ class MonitoringUtils: run_command([command, "switch-branch", f"{name}"], cwd=folder) self.print_user(info_log, success=True) except MonitoringException: - self.failed("fedpkg") + self.failed.append("fedpkg") self.print_user(info_log, success=False) def bump_release(self, name, folder): @@ -168,7 +168,7 @@ class MonitoringUtils: run_command(["rpmdev-bumpspec", f"{name}.spec"], cwd=folder) self.print_user(info_log, success=True) except MonitoringException: - self.failed("rpmdev-bumspec") + self.failed.append("rpmdev-bumspec") self.print_user(info_log, success=False) def commit_changes(self, commit_log, folder): @@ -181,7 +181,7 @@ class MonitoringUtils: run_command(["git", "commit", "-asm", commit_log], cwd=folder) self.print_user(info_log, success=True) except MonitoringException: - self.failed("git") + self.failed.append("git") self.print_user(info_log, success=False) def push_changes(self, folder, target, branch, force=False): @@ -196,7 +196,7 @@ class MonitoringUtils: run_command(cmd, cwd=folder) self.print_user(info_log, success=True) except MonitoringException: - self.failed("git/dist-git") + self.failed.append("git/dist-git") self.print_user(info_log, success=False) def pull_changes(self, folder, target, branch): @@ -209,7 +209,7 @@ class MonitoringUtils: run_command(cmd, cwd=folder) self.print_user(info_log, success=True) except MonitoringException: - self.failed("git/dist-git") + self.failed.append("git/dist-git") self.print_user(info_log, success=False) def open_pullrequest(self, base_url, username, namespace, name, branch, token): @@ -237,7 +237,7 @@ class MonitoringUtils: success = False pr_id = None pr_uid = None - self.failed("dist-git") + self.failed.append("dist-git") else: output = req.json() pr_id = str(output["id"]) @@ -260,7 +260,7 @@ class MonitoringUtils: self.print_user(info_log, success=True) return nevr.strip().decode("utf-8") except MonitoringException: - self.failed("fedpkg") + self.failed.append("fedpkg") self.print_user(info_log, success=False) def build_package(self, command, folder, target=None): @@ -275,7 +275,7 @@ class MonitoringUtils: run_command(command, cwd=folder) self.print_user(info_log, success=True) except MonitoringException: - self.failed("koji") + self.failed.append("koji") self.print_user(info_log, success=False) def chain_build_packages(self, command, packages, folder, target=None): @@ -295,7 +295,7 @@ class MonitoringUtils: run_command(command, cwd=folder) self.print_user(info_log, success=True) except MonitoringException: - self.failed("koji") + self.failed.append("koji") self.print_user(info_log, success=False) def get_build_tags(self, koji_url, nevr, expected_ends): @@ -353,7 +353,7 @@ class MonitoringUtils: info_log = f"Retrieving koji tags: {tags}" if not success: - self.failed("koji") + self.failed.append("koji") self.print_user(info_log, success=success) def create_update( @@ -387,7 +387,7 @@ class MonitoringUtils: run_command(command) self.print_user(info_log, success=True) except MonitoringException: - self.failed("bodhi") + self.failed.append("bodhi") self.print_user(info_log, success=False) def get_update_id(self, nevr, url): @@ -408,7 +408,7 @@ class MonitoringUtils: if (datetime.datetime.utcnow() - start).seconds > (15 * 60): success = False - self.failed("bodhi") + self.failed.append("bodhi") info_log = f"Update for {nevr} not created within 15 minutes" break @@ -568,7 +568,7 @@ class MonitoringUtils: info_log += f" - ran for: {(end - start_lookup).seconds}s" self.print_user(info_log, success=success) if not success: - self.failed("datagrepper") + self.failed.append("datagrepper") def lookup_ci_resultsdb(self, nevr, name, url): """ Check the CI results in the specified resultsdb for results about @@ -619,7 +619,7 @@ class MonitoringUtils: info_log += f" - ran for: {(end - start).seconds}s" self.print_user(info_log, success=success) if not success: - self.failed("resultsdb") + self.failed.append("resultsdb") def waive_update(self, command, updateid, prod=True, username=None, password=None): """ Waive all the tests results for the specified update using bodhi's @@ -645,7 +645,7 @@ class MonitoringUtils: run_command(command) self.print_user(info_log, success=True) except MonitoringException: - self.failed("waiverdb") + self.failed.append("waiverdb") self.print_user(info_log, success=False) def get_pr_flag( @@ -701,7 +701,7 @@ class MonitoringUtils: self.print_user(info_log, success=success) if not success: - self.failed("dist-git") + self.failed.append("dist-git") def merge_pr(self, base_url, username, namespace, name, pr_id, token): """ Merge the specified PR @@ -722,7 +722,7 @@ class MonitoringUtils: self.print_user(info_log, success=success) if not success: - self.failed("dist-git") + self.failed.append("dist-git") def finalize(self, start): """ End data returned. """ @@ -745,7 +745,7 @@ class MonitoringUtils: self.print_user(info_log, success=True) except (MonitoringException, Exception) as err: print(err) - self.failed("dist-git") + self.failed.append("dist-git") self.print_user(info_log, success=False) return side_tag_name